-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Linux] Add test logic to verify that launchURL is sent from Linux tv-casting-app to Linux tv-app. #33344
Merged
sharadb-amazon
merged 2 commits into
project-chip:master
from
shaoltan-amazon:test-launchUrl-Linux
May 9, 2024
Merged
[Linux] Add test logic to verify that launchURL is sent from Linux tv-casting-app to Linux tv-app. #33344
sharadb-amazon
merged 2 commits into
project-chip:master
from
shaoltan-amazon:test-launchUrl-Linux
May 9, 2024
+88
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
…-casting-app to Linux tv-app.
PR #33344: Size comparison from 947dc7c to eaa06d1 Decreases (2 builds for efr32)
Full report (77 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
sharadb-amazon
approved these changes
May 7, 2024
chrisdecenzo
approved these changes
May 9, 2024
hawk248
approved these changes
May 9, 2024
rquidute
pushed a commit
to rquidute/connectedhomeip
that referenced
this pull request
May 9, 2024
…-casting-app to Linux tv-app. (project-chip#33344)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33343
Problem
There is no CI check in place to verify that the launchUrl is still successfully sent from the Linux tv-casting-app to the Linux tv-app whenever a PR is created.
Solution Overview
Add test logic to the
run_tv_casting_test.py
file to verify that the launchUrl is being sent from the Linux tv-casting-app to the tv-app.Essentially, we will be parsing the output of the Linux tv-casting-app and the tv-app for strings of interest within a set timeout window. The output from both tv-casting-app and tv-app will also be written to their respective log files.
The following has been added to the test script:
ContentLauncherManager::HandleLaunchUrl TEST CASE ContentURL=https://www.test.com/videoid DisplayString=Test video
.InvokeResponseMessage
block and verify that it contains theexampleData
string. We will also parse for theReceived Command Response Data
string in the tv-casting-app output.Testing
Tested the script locally by running
python3 ./scripts/tests/run_tv_casting_test.py
and observing the output. Also verified that the updated test script works as expected in the CI check.